Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-670: Remove deprecated bitcoind crate #500

Merged
merged 3 commits into from
Dec 3, 2024
Merged

STR-670: Remove deprecated bitcoind crate #500

merged 3 commits into from
Dec 3, 2024

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Nov 29, 2024

Description

bitcoind has been deprecated (see the warning here: https://docs.rs/bitcoind/latest/bitcoind/ )

We should move to corepc which also is up-to-date with bitcoin version 28.0, while bitcoind is stuck in version 26.0.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

  • I had to bring bitcoincore-rpc for some compatibility without major rewrites in the integration tests, i.e. tests/.
  • I purposely did not add them to the root-level Cargo.toml since they are dev-dependencies and I don't want to add them to the compile bloat whenever we do cargo build (or save a file with rust-analyzer).

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

STR-670

@storopoli storopoli marked this pull request as ready for review December 2, 2024 13:39
@storopoli storopoli requested review from a team as code owners December 2, 2024 13:39
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.62%. Comparing base (a2d29b0) to head (e612b73).
Report is 6 commits behind head on main.

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   56.63%   56.62%   -0.01%     
==========================================
  Files         275      275              
  Lines       29192    29189       -3     
==========================================
- Hits        16532    16528       -4     
- Misses      12660    12661       +1     
Files with missing lines Coverage Δ
bin/bridge-client/src/descriptor.rs 50.48% <ø> (ø)
crates/btcio/src/rpc/client.rs 88.50% <100.00%> (ø)
crates/util/python-utils/src/drt.rs 87.17% <100.00%> (-0.07%) ⬇️

... and 6 files with indirect coverage changes

Copy link
Contributor

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@Zk2u Zk2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/btcio/Cargo.toml Show resolved Hide resolved
@storopoli storopoli merged commit 7d291ad into main Dec 3, 2024
18 checks passed
@storopoli storopoli deleted the STR-670 branch December 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants