-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-670: Remove deprecated bitcoind
crate
#500
Conversation
Signed-off-by: Jose Storopoli <[email protected]>
Signed-off-by: Jose Storopoli <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 56.63% 56.62% -0.01%
==========================================
Files 275 275
Lines 29192 29189 -3
==========================================
- Hits 16532 16528 -4
- Misses 12660 12661 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
bitcoind
has been deprecated (see the warning here: https://docs.rs/bitcoind/latest/bitcoind/ )We should move to
corepc
which also is up-to-date with bitcoin version 28.0, whilebitcoind
is stuck in version 26.0.Type of Change
Notes to Reviewers
bitcoincore-rpc
for some compatibility without major rewrites in the integration tests, i.e.tests/
.Cargo.toml
since they aredev-dependencies
and I don't want to add them to the compile bloat whenever we docargo build
(or save a file withrust-analyzer
).Checklist
Related Issues
STR-670