Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-525 sync preconditions #405

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

STR-525 sync preconditions #405

wants to merge 1 commit into from

Conversation

delbonis
Copy link
Contributor

Description

This introduces a concept called a "precondition" which we can check based on a sync event. A sync event can produce one of a couple of basic preconditions that we can run on the database first and abort early before trying to execute the sync event to determine if we should proceed.

This is in the interest of troubleshooting the sync issue we have.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 57.01%. Comparing base (0592017) to head (5a140fc).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/consensus-logic/src/precondition.rs 0.00% 13 Missing ⚠️
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   57.06%   57.01%   -0.06%     
==========================================
  Files         255      256       +1     
  Lines       27011    27006       -5     
==========================================
- Hits        15415    15398      -17     
- Misses      11596    11608      +12     
Files with missing lines Coverage Δ
crates/consensus-logic/src/precondition.rs 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant