ci: update to bitcoin 28.0 #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storopoli
force-pushed
the
storopoli/ci-bitcoin-28.0
branch
from
ba94a24 to
7edd20c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 57.47% 57.72% +0.24%
==========================================
Files 257 263 +6
Lines 27200 27541 +341
==========================================
+ Hits 15634 15897 +263
- Misses 11566 11644 +78
|
storopoli
force-pushed
the
storopoli/ci-bitcoin-28.0
branch
from
7edd20c to
01507d3
Compare
|
Draft I don't want to debug this before finishing #399 |
storopoli
force-pushed
the
storopoli/ci-bitcoin-28.0
branch
2 times, most recently
from
58ffbb4 to
3b94ddc
Compare
storopoli
force-pushed
the
storopoli/ci-bitcoin-28.0
branch
2 times, most recently
from
5e4c049 to
55cd451
Compare
storopoli
commented
Oct 17, 2024
storopoli
force-pushed
the
storopoli/ci-bitcoin-28.0
branch
from
3469898 to
86b9a94
Compare
|
Should be ready for review now |
Shouldn't be a breaking change for us, since we are not using any of the changed stuff. See: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-28.0.md#updated-rpcs
storopoli
force-pushed
the
storopoli/ci-bitcoin-28.0
branch
from
a455dc6 to
d89c9e6
Compare
storopoli
commented
Oct 17, 2024
delbonis
approved these changes
Oct 17, 2024
storopoli
added a commit
that referenced
this pull request
Oct 28, 2024
* ci: update to bitcoin 28.0 * fix(btcio): non-breaking changes in GetBlockChainInfo Shouldn't be a breaking change for us, since we are not using any of the changed stuff. See: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-28.0.md#updated-rpcs
storopoli
added a commit
that referenced
this pull request
Oct 28, 2024
* ci: update to bitcoin 28.0 * fix(btcio): non-breaking changes in GetBlockChainInfo Shouldn't be a breaking change for us, since we are not using any of the changed stuff. See: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-28.0.md#updated-rpcs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes a unofficial PPA for the official release in the(moved to an issue in Jira)bitcoinddocker imageGetBlockChainInfothat had a breaking change in 28.0: see https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-28.0.md#updated-rpcsType of Change
Checklist