Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AccountActivitiesRequest.cs #755

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

ooples
Copy link
Contributor

@ooples ooples commented Sep 28, 2024

Changed request model to match api documentation

Description

documentation for account activities method has changed and info can be found at https://docs.alpaca.markets/docs/account-activities

Fixes #753

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

I ran an API call to list account activities with these new changes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Changed request model to match api documentation
@OlegRa OlegRa self-assigned this Sep 29, 2024
@OlegRa OlegRa self-requested a review September 29, 2024 14:22
@OlegRa OlegRa added the bug Something isn't working label Sep 29, 2024
@OlegRa OlegRa added this to the SDK 7.x LTS milestone Sep 29, 2024
Copy link
Collaborator

@OlegRa OlegRa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlegRa OlegRa merged commit 1808100 into alpacahq:develop Sep 29, 2024
3 checks passed
OlegRa pushed a commit that referenced this pull request Sep 29, 2024
Changed request model to match API documentation

(cherry picked from commit 1808100)
OlegRa added a commit that referenced this pull request Nov 10, 2024
…st of account activity types, not a single one.
OlegRa added a commit that referenced this pull request Nov 10, 2024
…st of account activity types, not a single one.

(cherry picked from commit d0dc245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpaca api library bug
2 participants