-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor css modules to global BEM class #98
feat: refactor css modules to global BEM class #98
Conversation
related to #97 |
I need some help to fix test cases @almond-bongbong 🤗 |
I have made some changes to the 'feat/global-css' branch in my fork of the react-simple-toasts repository. These changes include fixing indentation and addressing test issues. I would like to request that you review and consider merging these changes into the repository. You can view the comparison of the changes here: The main changes include:
In particular, I kindly request your careful review of this specific line. There have been significant changes in this section that could potentially affect the behavior of the code. |
Thank you for your time and effort on this PR. I completely understand how hard it is to do open source, because I am also busy with work and can only find time to work on open source projects outside of work. I removed terser because developers will minify code when building. Keeping the source code readable makes it easier for developers to patch the code and deal with bugs |
I found some bug then fix them in this PR, well, maybe I should make new pr, but it's a bit cumbersome to synchronous code from new branch. |
Thank you very much. This code looks pretty solid. |
This pr add two feature
loadingText
option to customize the loading contentonTransitonEnd