Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor css modules to global BEM class #98

Merged

Conversation

hemengke1997
Copy link
Contributor

@hemengke1997 hemengke1997 commented Aug 25, 2024

This pr add two feature

  1. break change: refactor css modules to global class that using BEM convention. Currently, developers must import 'react-simple-toasts/dist/style.css' manually. This gives developers the ability to fully customize css styles
  2. add loadingText option to customize the loading content
  3. replace fixed 300ms exit timeout with onTransitonEnd

@hemengke1997
Copy link
Contributor Author

related to #97

@hemengke1997
Copy link
Contributor Author

I need some help to fix test cases @almond-bongbong 🤗

@almond-bongbong
Copy link
Owner

almond-bongbong commented Aug 26, 2024

I have made some changes to the 'feat/global-css' branch in my fork of the react-simple-toasts repository. These changes include fixing indentation and addressing test issues.

I would like to request that you review and consider merging these changes into the repository. You can view the comparison of the changes here:

hemengke1997/react-simple-toasts@feat/global-css...almond-bongbong:react-simple-toasts:feat/global-css

The main changes include:

  1. 🎨 Fix indent
  2. ✅ Fix tests

In particular, I kindly request your careful review of this specific line. There have been significant changes in this section that could potentially affect the behavior of the code.

@hemengke1997
Copy link
Contributor Author

hemengke1997 commented Aug 27, 2024

Thank you for your time and effort on this PR. I completely understand how hard it is to do open source, because I am also busy with work and can only find time to work on open source projects outside of work.

I removed terser because developers will minify code when building. Keeping the source code readable makes it easier for developers to patch the code and deal with bugs

@hemengke1997
Copy link
Contributor Author

I found some bug then fix them in this PR, well, maybe I should make new pr, but it's a bit cumbersome to synchronous code from new branch.

@almond-bongbong
Copy link
Owner

Thank you very much. This code looks pretty solid.

@almond-bongbong almond-bongbong merged commit df47c5c into almond-bongbong:master Sep 1, 2024
1 check passed
@hemengke1997 hemengke1997 deleted the feat/global-css branch September 3, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants