Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance maintainability and reusability #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hemengke1997
Copy link
Contributor

Hello, meet again! I did some refactoring mainly for reusability, extensibility and maintainability

@almond-bongbong
Copy link
Owner

I am honestly surprised and incredibly grateful for your proactive approach in maintaining the code. Given that this code has accumulated over a significant amount of time, there were bound to be areas that needed improvement. I will review the changes as quickly and positively as possible, and incorporate the updates into the codebase.

Thank you once again for your hard work.

almond-bongbong
almond-bongbong previously approved these changes Sep 7, 2024
Copy link
Owner

@almond-bongbong almond-bongbong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@almond-bongbong
Copy link
Owner

Could you please resolve the merge conflicts in this PR?

@hemengke1997
Copy link
Contributor Author

Sorry for the late reply. I've resolved the conflict, please check it and feel free to modify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants