-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make results' limits configurable (fixes #347) #1331
base: main
Are you sure you want to change the base?
Make results' limits configurable (fixes #347) #1331
Conversation
7c39ca2
to
790340f
Compare
Hello, Just checking to see if there is a possibility of this PR to get merged soon and what it would take to get this merged :) Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@indradeepchowdhury as far as I remember, @baev had some concerns in terms of implementation. Need to double-check with him. |
Thanks for the update @sskorol. @baev would it be possible to expedite this feature. This would be a super cool feature to have. |
Hi @sskorol. Thanks for jour work on providing such feature. |
Hi @pbandura, I don't. When I initially pushed it, it was a fully working feature. I talked to maintainers directly. And they promised to check. Seems like they didn't have time. Now I see there's a conflict. I can resolve it. And then you will be able to build a new version with this feature from sources if it's important for you. |
Hi @sskorol I think this feature would be pretty cool and I am looking forward to using it. This feature will allow us to align the history with our Sprint duration or even let us increase the history limit to a month for proper tracking 🙂 |
There were several places in code with hardcoded limits for items rendered on charts. It was really inconvenient for the end-user who had to rebuild the entire project to make limits configurable. This fix moves the actual configuration into an Aggregator interface which is implemented by key plugins. Moreover, a user can now control the limits via ALLURE_RESULTS_LIMIT env variable that could be set before report's generation. Note that a newly added method was intentionally made static as some of the APIs that adjust the limits are also static.
790340f
to
50c63b0
Compare
@indradeepchowdhury @pbandura force-pushed changes with conflicts' resolution. Now you can build the report on your own with this feature. |
@sskorol @indradeepchowdhury @baev Why didn't you guys apply this? |
I don't like the current implementation because:
Besides that, our team is heavily focused on Allure 3 development right now, so this change isn't really in priority right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
Please resolve conflicts for this PR.
Context
There were several places in code with hardcoded limits for items rendered on charts. It was really inconvenient for the end-user who had to rebuild the entire project to make limits configurable.
This fix moves the actual configuration into an Aggregator interface which is implemented by key plugins. Moreover, a user can now control the limits via
ALLURE_RESULTS_LIMIT
env variable that could be set before the report's generation. Note that a newly added method was intentionally made static as some of the APIs that adjust the limits are also static.Fixes #347
Checklist