Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosscompile allure-scalatest to scala 2.12 & 2.13 #1106

Closed
wants to merge 2 commits into from
Closed

Crosscompile allure-scalatest to scala 2.12 & 2.13 #1106

wants to merge 2 commits into from

Conversation

atais
Copy link

@atais atais commented Jul 30, 2024

fixes #1104

Todo list

  • compile 2.12
  • compile 2.13
  • publish with 2.12 suffix
  • publish with 2.13 suffix
  • publish 2.12 sources & javadoc
  • publish 2.13 sources & javadoc
  • disable publishing jar without suffix

Context

https://mvnrepository.com/artifact/io.qameta.allure/allure-scalatest
missing _2.12 and _2.13 suffixes

Checklist

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2024

CLA assistant check
All committers have signed the CLA.

@baev baev added the type:bug Something isn't working label Jul 30, 2024
@baev
Copy link
Member

baev commented Jul 30, 2024

@atais, awesome! Please, make sure the scala doc and the sources are published as well (as per Maven Central requirement)

@atais
Copy link
Author

atais commented Jul 30, 2024

@atais, awesome! Please, make sure the scala doc and the sources are published as well (as per Maven Central requirement)

Unfortunately:

Shortcomings
...

  • publishing for source/javadoc jars are supported for default-variant of Scala version only.

https://github.com/prokod/gradle-crossbuild-scala/blob/master/README.md?plain=1#L22

And I am not sure there is anything that can be done about it

@baev
Copy link
Member

baev commented Jul 30, 2024

I'm afraid that Maven Central may not accept the release without the sources & scala doc included. As far as I know, different variants are basically suffixes for the artefact name, and each artefact needs to have sources and docs published.

@atais
Copy link
Author

atais commented Jul 30, 2024

@baev I am afraid I am not able to fix it then with the plugin.

I know however, that I have removed a lot of your code during that process, which seemed to provide all the items you're mentioning... However my gradle skill is not high enough to fix your solution :-)

Maybe you could check it out, it is dated back to 2019 but maybe you'd remember the intention 😄

@baev
Copy link
Member

baev commented Jul 30, 2024

I already did it yesterday (after you created an issue), and I found absolutely no clue how to support cross-builds correctly. The old code from 2019 isn't working either)

@atais
Copy link
Author

atais commented Jul 30, 2024

hah, great :D

in that case, maybe you could at least hardcode the version to 2.13 so it is being properly published?
and I will think how to publish 2.12 in the meantime

@baev
Copy link
Member

baev commented Jul 30, 2024

@atais see #1107

I disabled default publication, added scaladoc & sources for new publications, fixed the poms

@atais
Copy link
Author

atais commented Jul 30, 2024

thanks a lot

@atais atais closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞: restore support of scala 2.12 & 2.13 for allure-scalatest
3 participants