Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Harmony and MonoMod to support .NET 8 #449

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Update Harmony and MonoMod to support .NET 8 #449

merged 2 commits into from
Mar 4, 2024

Conversation

TonEnfer
Copy link
Contributor

@TonEnfer TonEnfer commented Feb 7, 2024 •
edited
Loading

Context

Checklist

delatrie
delatrie requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@delatrie delatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @TonEnfer !
Thank you for the contribution!

Let's update straight to Harmony 2.3.0 (it was released a couple of days ago).

Allure.SpecFlowPlugin/Allure.SpecFlowPlugin.csproj Outdated Show resolved Hide resolved
Allure.SpecFlowPlugin/Allure.SpecFlowPlugin.csproj Outdated Show resolved Hide resolved
@TonEnfer TonEnfer requested a review from delatrie March 4, 2024 07:00
@delatrie delatrie added type:dependencies Pull requests that update a dependency type:bug Something isn't working labels Mar 4, 2024
@delatrie delatrie added type:dependencies Pull requests that update a dependency and removed type:dependencies Pull requests that update a dependency type:bug Something isn't working labels Mar 4, 2024
@delatrie delatrie linked an issue Mar 4, 2024 that may be closed by this pull request
.Net 8 Support xUnit - Harmony -> MonoMod Dependency #434
Closed
3 tasks
@delatrie delatrie merged commit b8a1786 into allure-framework:main Mar 4, 2024
6 of 8 checks passed
@TonEnfer TonEnfer deleted the Update_monomod branch March 6, 2024 08:33
@AlexBar
Copy link

AlexBar commented Mar 18, 2024

Could you guys update nuget package to include these changes?

@delatrie delatrie mentioned this pull request Mar 25, 2024
Merged
@delatrie
Copy link
Contributor

delatrie commented Apr 2, 2024

@AlexBar Sorry for the delay. Version 2.12.0 that contains the fix has just been released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delatrie delatrie delatrie approved these changes

Assignees
No one assigned
Labels
theme:build theme:specflow theme:xunit type:dependencies Pull requests that update a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net 8 Support xUnit - Harmony -> MonoMod Dependency
3 participants
@TonEnfer @AlexBar @delatrie