Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective run #389

Closed
wants to merge 13 commits into from
Closed

Selective run #389

wants to merge 13 commits into from

Conversation

delatrie
Copy link
Contributor

@delatrie delatrie commented Oct 3, 2023

//: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)

Context

Checklist

  - Remove net462 target from allure-specflow (net462 already
    implements netstandard2.0).
  - Fix allure-specflow README (version references, examples).
  - Increase SpecFlow.NUnit and SpecFlow.Tools.MsBuild.Generation
    to 3.9.52 (max version that doesn't break SpecFlow.SharedSteps).
  - Tiny refactoring of AllureBindingInvoker.cs
  - make async Step, Before and After obey .NET's ExecutionContext capturing rules
  - refactor CoreStepsHelper to be more testable
  - write tests for CoreStepsHelper's Step, Before and After

More tests are needed to fully cover CoreStepsHelper.

Fixes #383
Fixed #388
@delatrie
Copy link
Contributor Author

delatrie commented Oct 4, 2023

Will be split into multiple smaller PRs

@delatrie delatrie closed this Oct 4, 2023
@delatrie delatrie deleted the selective-run branch October 21, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant