Set Allure.Xunit's TFMs to netstandard2.0 and netcoreapp3.1

allure-framework · Mar 28, 2024 · cd3e89b · cd3e89b
1 parent d424840
commit cd3e89b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Allure.XUnit/Allure.XUnit.csproj b/Allure.XUnit/Allure.XUnit.csproj
@@ -2,7 +2,7 @@
 
     <PropertyGroup>
         <AssemblyName>Allure.Xunit.reporters</AssemblyName>
-        <TargetFrameworks>netcoreapp2.0;netstandard2.1;net5.0;net6.0</TargetFrameworks>
+        <TargetFrameworks>netstandard2.0;netcoreapp3.1</TargetFrameworks>
         <IsPackable>true</IsPackable>
         <Authors>Shumakov Ivan</Authors>
         <Description>Create beautiful reports from your xUnit.net tests.</Description>

diff --git a/Allure.XUnit/AllureMessageSink.cs b/Allure.XUnit/AllureMessageSink.cs
@@ -161,7 +161,7 @@ void OnTestFinished(MessageHandlerArgs<ITestFinished> args)
                 });
             }
 
-            this.allureTestData.Remove(test, out _);
+            this.allureTestData.TryRemove(test, out _);
         }
 
         AllureXunitTestData GetOrCreateTestData(ITest test)

diff --git a/Allure.XUnit/AllureXunitHelper.cs b/Allure.XUnit/AllureXunitHelper.cs
@@ -66,8 +66,8 @@ internal static void StartAllureTestCase(
 
         internal static void ApplyTestFailure(IFailureInformation failure)
         {
-            var trace = string.Join('\n', failure.StackTraces);
-            var message = string.Join('\n', failure.Messages);
+            var trace = string.Join("\n", failure.StackTraces);
+            var message = string.Join("\n", failure.Messages);
             var status = failure.ExceptionTypes.Any(
                 exceptionType => !exceptionType.StartsWith("Xunit.Sdk.")
             ) ? Status.broken : Status.failed;
-Original file line number
+Diff line change
@@ Expand Up / @@ -161,7 +161,7 @@ void OnTestFinished(MessageHandlerArgs<ITestFinished> args) @@
                     });
                 }
-                this.allureTestData.Remove(test, out _);
+                this.allureTestData.TryRemove(test, out _);
             }
             AllureXunitTestData GetOrCreateTestData(ITest test)
@@ Expand Down @@