Dont fail all scenarios if Harmony patching fails (#437)

Closes #436
allure-framework · Nov 28, 2023 · 1b48e19 · 1b48e19
1 parent 51b6f15
commit 1b48e19
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/Allure.SpecFlowPlugin/AllureBindingInvoker.cs b/Allure.SpecFlowPlugin/AllureBindingInvoker.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Specialized;
+using System.IO;
 using Allure.Net.Commons;
 using Allure.SpecFlowPlugin.SelectiveRun;
 using TechTalk.SpecFlow;
@@ -43,7 +44,8 @@ IUnitTestRuntimeProvider unitTestRuntimeProvider
         {
             this.testRunnerManager = testRunnerManager;
             AllureSpecFlowPatcher.EnsureTestPlanSupportInjected(
-                unitTestRuntimeProvider
+                unitTestRuntimeProvider,
+                WriteErrorToFileSafe
             );
         }
 
@@ -75,6 +77,15 @@ out duration
             );
         }
 
+        static void WriteErrorToFileSafe(Exception e)
+        {
+            try
+            {
+                File.WriteAllText(".allure_patch_error", e.ToString());
+            }
+            catch (Exception) { }
+        }
+
         (object, TimeSpan) ProcessHook(
             IBinding binding,
             IContextManager contextManager,

diff --git a/Allure.SpecFlowPlugin/SelectiveRun/AllureSpecFlowPatcher.cs b/Allure.SpecFlowPlugin/SelectiveRun/AllureSpecFlowPatcher.cs
@@ -1,4 +1,5 @@
 using HarmonyLib;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
@@ -13,15 +14,23 @@ static class AllureSpecFlowPatcher
         static bool isTestPlanSupportInjected= false;
 
         internal static void EnsureTestPlanSupportInjected(
-            IUnitTestRuntimeProvider unitTestRuntimeProvider
+            IUnitTestRuntimeProvider unitTestRuntimeProvider,
+            Action<Exception> logError
         )
         {
             if (isTestPlanSupportInjected)
             {
                 return;
             }
 
-            InjectTestPlanSupport(unitTestRuntimeProvider);
+            try
+            {
+                InjectTestPlanSupport(unitTestRuntimeProvider);
+            }
+            catch (Exception e)
+            {
+                logError(e);
+            }
             isTestPlanSupportInjected = true;
         }