Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Upgrade to RestSharp v110 #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore!: Upgrade to RestSharp v110 #4

wants to merge 2 commits into from

Conversation

kamranayub
Copy link
Contributor

@kamranayub kamranayub commented Dec 4, 2023 •
edited
Loading

I had some other dependency upgrades that use RS v110 and this was incompatible. RestSharp v107+ had breaking changes, as well as uses System.Text.Json as the default JSON serializer.

BREAKING CHANGES

  • Upgrade to RestSharp v110
  • Remove Newtonsoft.Json

Changes

  • Add support for deserializing as strongly-typed response
  • Handle stats field with a GogStatsConverter
  • Upgrade tests to .NET 7 to get rid of warnings
Starting test execution, please wait...

A total of 1 test files matched the specified pattern.

Passed!  - Failed:     0, Passed:     1, Skipped:     0, Total:     1, Duration: 823 ms - GOGDotNet.Tests.dll (net7.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kamranayub