Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add client gen for todo app #3

Merged
merged 2 commits into from
Nov 29, 2024
Merged

add client gen for todo app #3

merged 2 commits into from
Nov 29, 2024

Conversation

ArcturusZhang
Copy link
Collaborator

No description provided.

@ArcturusZhang ArcturusZhang marked this pull request as draft November 25, 2024 07:56
@ArcturusZhang
Copy link
Collaborator Author

Issues noticed:

  1. NoAuth is not working. This spec has @useAuth(NoAuth) on the Users namespace. But the generated Users subclient is actually not affected at all.
  2. ApiKeyAuth<cache, "session-id"> is not quite working in the cache way.
  3. The @visibility("none") property Validated is exposed in the client generated result (known issue for generator)

@ArcturusZhang ArcturusZhang marked this pull request as ready for review November 29, 2024 02:33
@ArcturusZhang
Copy link
Collaborator Author

Issues in the current client gen will be added into this issue to track

@ArcturusZhang ArcturusZhang merged commit b0e93c6 into allenjzhang:main Nov 29, 2024
@ArcturusZhang ArcturusZhang deleted the add-client-gen-for-todoapp branch November 29, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ArcturusZhang