Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[risk=no][no-ticket] Add some logs to trace billing sync related issues #8970

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tarekmamdouh
Copy link
Collaborator

@tarekmamdouh tarekmamdouh commented Nov 22, 2024

We're seeing strange billing sync issues that we cannot understand, where a user updates their billing account however the billing active status stays as Inactive.
Also I see another strange issue where the actual billing account name was not updated after being linked successfully in gcp (https://precisionmedicineinitiative.atlassian.net/browse/RW-13997)
I am adding some logs to trace the code and better understand the root cause of the issue.


PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

Comment on lines +481 to +484
log.info(
String.format(
"Billing account for workspace %s is already set to %s",
workspace.getWorkspaceNamespace(), newBillingAccountName));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if bug is here, then billing account name and billing status should be updated at the same time. But for our case, looks account_name is not changing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's correct, however I wanted to have a better insight into what happens in this method generally even if it gets called with the same billing account name. Just to rule out any potential issues.

@tarekmamdouh tarekmamdouh marked this pull request as ready for review November 25, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants