[DC-3485] Update generate_ehr_upload_pids.py to automatically exclude sites without submissions #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hiro-mishima
commented
Nov 14, 2023
•
hiro-mishima
commented
- Before the change, you had to manually copy and paste the SELECT statement to the view definition for the update. With this change, you do not need to do so: the DDL will re-create the view for you.
- Curation playbook is updated accordingly.
hiro-mishima
changed the title
nishanthpp93
reviewed
Dec 1, 2023
Comment on lines
+34
to
+39
| person_id, | ||
| current_datetime() AS report_run_time, | ||
| Org_ID as org_id, | ||
| HPO_ID as hpo_id, | ||
| Site_Name as site_name, | ||
| TIMESTAMP_MICROS(t.last_modified_time * 1000) AS latest_upload_time |
There was a problem hiding this comment.
@hiro-mishima Our biggest problem with the ehr_upload_pids was the "Query too large" error, which prevented us from doing this. This feels like it is making the query more complicated. Let me know if you've already tested this and it works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.