Same code and QCs, but updated format #1439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the format a bit - added PASS if QC passes. I also hard coded rt_dataset as this parameter does not change
|
@ksdkalluri when you have time, please approve this. I just updated the format but it is the same code. |
ksdkalluri
reviewed
Feb 13, 2023
| cur_project): | ||
| def get_data_input(ct_ser_dataset, new_ser_ct_dataset, cur_out_project, cur_project): | ||
|
|
||
| rt_dataset='R2020q4r1_antibody_quest' |
There was a problem hiding this comment.
@kouamea although the dataset name doesn’t change we do not want our prod dataset names to be publicly available. can you revert this back to a parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the format a bit - added PASS if QC passes. I also hard coded rt_dataset as this parameter does not change