MI-39: Convert to Typescript & support CJS #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styler3
requested changes
Nov 11, 2024
There was a problem hiding this comment.
@kai-nguyen-aligent Looks good. I have requested one minor change and also had a question about backwards compatibility.
styler3
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to use this package with Nx, I have bumped into lot's of issues with eslint & prettier because we only support ESM while Nx plugins & tools chain are still CJS by default. As a result, I create this PR to:
cjsandmjsfiles for consumption instead of directly publish our code insrcfolder.eslint-plugin-prettierfrom oureslintconfiguration because of the following reasons:prettierseparately fromeslintwhen it comes to formatting.eslint-plugin-prettieris a plugin that helps execute formatting through eslint. For our use case,eslint-config-prettieris more suitable.eslint-plugin-prettierin CJS resolve into a bug as described here.