Skip to content

Commit

Permalink
MI-39 Remove explicit format steps
Browse files Browse the repository at this point in the history
The format checks are handled through ESLint. Now that ESLint is fixed
up to be functioning properly, there is no more need for separate format
scripts.
  • Loading branch information
styler3 committed Nov 19, 2024
1 parent 7aec3b9 commit d93d6ce
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 29 deletions.
25 changes: 0 additions & 25 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,28 +30,3 @@ jobs:

- name: Run Tests
run: pnpm test

code-quality:
name: 🕵️‍♀️ Code Quality
runs-on: ubuntu-latest
steps:
- name: Checkout Repository
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref }}

- name: Fetch target
run: git fetch origin ${{ github.event.pull_request.base.ref }}

- uses: pnpm/[email protected]
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: 'pnpm'

- name: Install
run: pnpm install

- name: Code Quality Check
run: pnpm format:check
5 changes: 1 addition & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@
],
"scripts": {
"test": "tsc && eslint .",
"build": "rollup -c",
"format": "prettier --ignore-path .prettierignore --check \"**/*.+(js|ts|json)\"",
"format:check": "pnpm run format",
"format:fix": "prettier --ignore-path .prettierignore --write \"**/*.+(js|ts|json)\""
"build": "rollup -c"
},
"dependencies": {
"@eslint/compat": "^1.2.2",
Expand Down

0 comments on commit d93d6ce

Please sign in to comment.