Merge pull request #48 from aligent/fix/suggest_export

Fix/suggest export
aligent · Nov 15, 2024 · 8f73e42 · 8f73e42
2 parents 8809af0 + fdf3ef3
commit 8f73e42
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/export/Model/Data/Suggest/SearchTermsFileGenerator.php b/src/export/Model/Data/Suggest/SearchTermsFileGenerator.php
@@ -37,9 +37,6 @@ public function generateFile(string $directory): string
     {
         $defaultLocale = $this->generalConfig->getDefaultLocale();
         $searchTerms = $this->getSearchTerms();
-        if (empty($searchTerms)) {
-            return '';
-        }
 
         $filename = $directory . DIRECTORY_SEPARATOR .
             ($this->isBlacklist ? self::BLACKLIST_FILENAME : self::WHITELIST_FILENAME);

diff --git a/src/export/Model/GenerateSuggestExport.php b/src/export/Model/GenerateSuggestExport.php
@@ -55,7 +55,16 @@ public function execute(): void
             // create all required files
             $files = [];
             foreach ($this->fileGenerators as $fileGenerator) {
-                $files[] = $fileGenerator->generateFile($directory);
+                $file = $fileGenerator->generateFile($directory);
+                if (!empty($file)) {
+                    $files[] = $fileGenerator->generateFile($directory);
+                }
+            }
+
+            // only create the zip file and export entity if there are files to include
+            if (empty($files)) {
+                $this->logger->info(__METHOD__ . ': No files to export');
+                return;
             }
 
             // create zip file