Ensure "temporary" table is always dropped after indexing

aligent · Nov 17, 2024 · 3cf2a53 · 3cf2a53
1 parent 58a2c8f
commit 3cf2a53
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/src/index/Model/ProductIndexer.php b/src/index/Model/ProductIndexer.php
@@ -77,15 +77,20 @@ public function executeList(array $ids): void
             // create temporary table to handle changelogs
             $this->tempTable->generateTempTableName();
             $this->tempTable->create();
-            foreach ($this->dimensionProvider->getIterator() as $dimension) {
-                try {
-                    $this->executeByDimensions($dimension, new \ArrayIterator($ids));
-                } catch (FileSystemException|RuntimeException) {
-                    continue;
+            // try block here is nested to ensure that if the table was created, it gets dropped at the end
+            try {
+                foreach ($this->dimensionProvider->getIterator() as $dimension) {
+                    try {
+                        $this->executeByDimensions($dimension, new \ArrayIterator($ids));
+                    } catch (FileSystemException|RuntimeException) {
+                        continue;
+                    }
                 }
+                $this->insertChangelogRecords->execute();
+            } finally {
+                // we want to ensure that the "temporary" table is always dropped
+                $this->tempTable->drop();
             }
-            $this->insertChangelogRecords->execute();
-            $this->tempTable->drop();
         } catch (\Exception $e) {
             $this->logger->critical($e->getMessage(), ['exception' => $e]);
         }