Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/additional serverless deploy permissions #52

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Feature/additional serverless deploy permissions #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d233fab
Add TagRole permission
May 1, 2024
1c5e3a7
add lambda:ListTags to allow the deploy user to access tag information
Oct 1, 2024
9459389
prettier update
Oct 1, 2024
21f16df
resolve conflict
Oct 1, 2024
833b6c6
prettier update
Oct 1, 2024
6682fa9
update test
Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/serverless-deploy-iam/bin/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ export class ServiceDeployIAM extends cdk.Stack {
"iam:GetRole",
"iam:DeleteRole",
"iam:UpdateRole",
"iam:TagRole",
"iam:GetRolePolicy",
"iam:DeleteRolePolicy",
"iam:PutRolePolicy",
Expand Down Expand Up @@ -476,7 +477,11 @@ export class ServiceDeployIAM extends cdk.Stack {
name: "LAMBDA",
prefix: `arn:aws:lambda:${region}:${accountId}:function:`,
qualifiers: [`${serviceName}*`],
actions: ["lambda:GetFunction", "lambda:InvokeFunction"],
actions: [
"lambda:GetFunction",
"lambda:InvokeFunction",
"lambda:ListTags",
],
},
{
name: "IAM",
Expand Down
6 changes: 5 additions & 1 deletion packages/serverless-deploy-iam/test/deploy-role.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,11 @@ describe("Deploy user policy", () => {
PolicyDocument: {
Statement: arrayWith(
objectLike({
Action: ["lambda:GetFunction", "lambda:InvokeFunction"],
Action: [
"lambda:GetFunction",
"lambda:InvokeFunction",
"lambda:ListTags",
],
Effect: "Allow",
Resource: [
{
Expand Down
Loading