-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/do 1587 migrate to yarn #1405
Conversation
6734bd6
to
025ddd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config looks good, just need to update the workflows and package.json scripts to go through the NX targets / executors so it picks up the config there and is cacheable.
bd99134
to
92782a7
Compare
9152d28
to
8203472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Description of the proposed changes
This is a big change so apologies for the big PR 🙏 Most of it is repeated config files for each package so hopefully it shouldn't take too long to review.
Converts our cdk-constructs to use yarn berry + nx for mono repo. I haven't changed any behaviour (at least not intentionally) so builds, publishing, etc should still work as before, just using a different bit of tech underneath.
I wanted to use PnP with yarn but this doesn't support nx project schemas 😞 (even though the nx docs say it does...).
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback