Hotfix: Allow multiple stacks #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… safer defaults Only create auth table if name is passed Add prop to pass dashboard name Set default dashboard name to include the stack name so that a second stack with no prop set won't cause a failed deployment
TheOrangePuff
requested changes
Jul 16, 2024
TheOrangePuff
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Update the mesh construct so that it can be deployed multiple times to the same account with the same defaults. Currently if you deploy it more than once it will fail and rollback due to creating a dashboard and dynamo DB table with the same name in both stacks. This PR removes the default dynamo DB table and updates the dashboard to include the stack name so it will not conflict.
Notes to PR author
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback