Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/minor tweak for redirection message #1388

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

jswift
Copy link
Contributor

@jswift jswift commented Jun 14, 2024

Description of the proposed changes

  • Redirection message now contains tag
  • Redirection message now contains permanently or temporarily based on header (pedantry corner)
  • Redirection body replacement now includes 307 and 308, and caching also happens for 308

Screenshots (if applicable)

  • N/A

Other solutions considered (if any)

  • Not bothering

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link
Contributor

@crispy101 crispy101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jswift jswift merged commit 04d355a into main Jun 14, 2024
1 check passed
@jswift jswift deleted the feature/minor-tweak-for-redirection-message branch June 14, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants