Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional props for construct name #1353

Merged
merged 4 commits into from
May 6, 2024
Merged

Add optional props for construct name #1353

merged 4 commits into from
May 6, 2024

Conversation

gowrizrh
Copy link
Contributor

@gowrizrh gowrizrh commented May 3, 2024 •
edited
Loading

Description of the proposed changes

  • Adds optional names to ECS cluster, service and repository, looks more readable in the AWS console
  • Removes the any IP4v security group rule in favour for service's security group (the other option is to allow VPC CIDR block if other things in the VPC needs access)

@gowrizrh gowrizrh changed the title feat: Add optional props for name Add optional props for construct name May 3, 2024
TheOrangePuff
TheOrangePuff previously approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

packages/graphql-mesh-server/lib/maintenance.ts Outdated Show resolved Hide resolved
@gowrizrh
feat: add codepipeline name prop
0c75c5e 
update security group to vpc cidr so lambda can access
@gowrizrh
Copy link
Contributor Author

gowrizrh commented May 3, 2024

@TheOrangePuff Ready for a re-review

  • Added optional name prop for code pipeline service
  • Use VPC IPv4 address
  • Add authenticationTable prop to top level prop so it can be passed down (currently there is no way to customise this or disable it. Setting '' can act as disable for now)

@gowrizrh gowrizrh merged commit dc1d19e into main May 6, 2024
1 check passed
@gowrizrh gowrizrh mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamJHall AdamJHall AdamJHall approved these changes

@TheOrangePuff TheOrangePuff TheOrangePuff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gowrizrh @TheOrangePuff @AdamJHall