Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide enough time to handle ten URLs in a chunk #1318

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

crispy101
Copy link
Contributor

Description of the proposed changes

  • Recaching one URL usually takes ~ 10 seconds. The maximum number of URLs in one recaching request chunk is 10, so 60 seconds was not enough to finish them up before the timeout. This change provides ample time for the lambda to finish the recaching.

Screenshots (if applicable)

Other solutions considered (if any)

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

TheOrangePuff
TheOrangePuff previously approved these changes Feb 22, 2024
Chris Park added 2 commits March 18, 2024 12:03
@crispy101
Copy link
Contributor Author

crispy101 commented Mar 18, 2024

No change, but could you please reveiw this again.

…. Otherwise, the queue message will get picked after 60 seconds by another lambda instance"

This reverts commit cdfbccb.
@crispy101 crispy101 merged commit 852082f into main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants