Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Graphql Mesh changes from DO branch #1108

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Conversation

AdamJHall
Copy link
Contributor


Description of the proposed changes
This PR ports the changes across to the epic from the DO-1285 branch.

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

gowrizrh
gowrizrh previously approved these changes Oct 13, 2023
Copy link
Contributor

@gowrizrh gowrizrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, it maybe worth updating @types/yaml under devDependencies

@AdamJHall AdamJHall requested a review from gowrizrh October 13, 2023 03:17
Copy link
Contributor

@gowrizrh gowrizrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdamJHall AdamJHall merged commit 53a625f into epic/cdk-v2 Oct 13, 2023
1 check passed
@AdamJHall AdamJHall deleted the feature/graphql-mesh branch October 13, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants