feat: add optional props for name

aligent · May 3, 2024 · 6bfa936 · 6bfa936
1 parent ea16a27
commit 6bfa936
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/graphql-mesh-server/lib/fargate.ts b/packages/graphql-mesh-server/lib/fargate.ts
@@ -141,6 +141,27 @@ export interface MeshServiceProps {
    * @default authentication-table
    */
   authenticationTable?: string;
+
+  /**
+   * Specify a name for the ECS cluster
+   * 
+   * @default - AWS generated cluster name
+   */
+  clusterName?: string
+
+  /**
+   * Specify a name for the GraphQL service
+   * 
+   * @default - AWS generated service name
+   */
+  serviceName?: string
+
+  /**
+   * Specify a name for the ECR repository
+   * 
+   * @default - AWS generated repository name
+   */
+  repositoryName?: string
 }
 
 export class MeshService extends Construct {
@@ -171,6 +192,7 @@ export class MeshService extends Construct {
     this.repository =
       props.repository ||
       new ecr.Repository(this, "repo", {
+        repositoryName: props.repositoryName !== undefined ? props.repositoryName : undefined,
         removalPolicy: RemovalPolicy.DESTROY,
         autoDeleteImages: true,
       });
@@ -219,6 +241,8 @@ export class MeshService extends Construct {
       vpc: this.vpc,
       containerInsights:
         props.containerInsights !== undefined ? props.containerInsights : true,
+      clusterName:
+        props.clusterName !== undefined ? props.clusterName : undefined,
     });
 
     const environment: { [key: string]: string } = {};

diff --git a/packages/graphql-mesh-server/lib/maintenance.ts b/packages/graphql-mesh-server/lib/maintenance.ts
@@ -72,11 +72,7 @@ export class Maintenance extends Construct {
       resources: [efsVolume.fileSystemArn, accessPoint.accessPointArn],
     });
 
-    efsVolumeSecGroup.addIngressRule(
-      Peer.anyIpv4(), // Can't get the IP address of each container as we don't know them at deploy time!
-      Port.tcp(2049),
-      "File access"
-    );
+    efsVolume.connections.allowDefaultPortFrom(props.fargateService.connections);
 
     efsVolume.grantReadWrite(props.fargateService.taskDefinition.taskRole);
     props.fargateService.taskDefinition.addToTaskRolePolicy(accessPolicy);