Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] File save dialog now requires a valid filename #2602

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

waaake
Copy link
Contributor

@waaake waaake commented Nov 22, 2024

Validating the filename to ensure that the file does not gets saved with just the extension

Description

  • Added a Validation to the file and template save process to ensure we have a valid filename to save to and not just the extension in the saved filename.

Features list

Implementation remarks

  • The validation process involves showing up a dialog box prompting user to provide a correct filename to save. This dialog box is recurring till the time a valid filename is entered for saving the file.

@waaake waaake self-assigned this Nov 22, 2024
@fabiencastan fabiencastan added this to the Meshroom 2024.1.0 milestone Nov 23, 2024
@waaake waaake marked this pull request as draft November 26, 2024 11:28
@waaake waaake force-pushed the fix/ValidateSaveFile branch from 011dffc to af2c19e Compare November 26, 2024 13:36
@waaake waaake marked this pull request as ready for review November 26, 2024 13:37
@waaake waaake force-pushed the fix/ValidateSaveFile branch from af2c19e to 89c4f54 Compare November 29, 2024 14:54
@waaake waaake requested a review from yann-lty November 29, 2024 14:55
@waaake
Copy link
Contributor Author

waaake commented Nov 29, 2024

Thanks @yann-lty for the wonderful suggestions on the PR, this is working as expected with function and reused implementation of MessageDialog as a warning.

The only annoyance that I get is of this error at the moment,
Created Graphical Object was not placed in the Graphics Scene
With myself trying to pass a parent which comes from the main.qml (parent.parent) or (root.parent) instead of root still somehow causes this to be raised.

Validating the filename to ensure that the file does not gets saved with just the extension
@waaake waaake force-pushed the fix/ValidateSaveFile branch from 89c4f54 to 32a493d Compare December 2, 2024 12:12
@yann-lty yann-lty merged commit feedad4 into develop Dec 3, 2024
3 checks passed
@yann-lty yann-lty deleted the fix/ValidateSaveFile branch December 3, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants