Qt6.6.3 / PySide6.6.3.1 upgrade #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes all the "Injection of parameters into signal handlers is deprecated. Use JavaScript functions with formal parameters instead." warnings.
Qt3D.Extras cannot be updated to 2.6 yet, otherwise there are errors.
With Qt6, OpenGL is not used directly anymore, and we thus must use the RHI backend, set to version 1.0. The SphericalHarmonics shaders, which were previously written in OpenGL, need to be updated accordingly.
Call the `QGeometry` objects from the correct module, and initialize correctly the Camera object upon the construction of the TrackballController object.
Additionally harmonize comments and explicitly declare parameters for slots that need them.
`PointSize` is not supported by RHI.
The fit must be automatically triggered when the size of the image changes. In case the image size remains the same but the orientation tag is updated, this means that the displayed size of the image has changed (with the orientation taken into account, the width and height might end up being inverted), so the fit should also be triggered.
Disable and hide the wireframe mode as the shaders need to be updated for RHI.
When converting the `StatusData` to a dictionary, only data attributes should be stored in said dictionary. With Qt6, the `objectNameChanged` signal, of type `SignalInstance`, is added to the dictionary. It needs to be removed manually as it is not JSON-serializable. Otherwise, the nodes cannot be computed anymore.
Replace `DiffuseSpecularMaterial`, which does not seem to support correctly textures anymore, with `DiffuseMapMaterial`.
With the Sequence Player always enabled by default, the `fit()` function must be triggered at the right moment, and only once the layout has been correctly initialized; otherwise, zoom factors may become negative and the images will not be placed correctly in the viewer. Changes in the orientation tag must be handled independently from the state of the zoom factor.
Use a single light entity instead of one per camera. Use directional light instead of point light. Add camera relative directional light controller.
Default camera up should be accurate and consistent with camera view center. Default camera up vector is not refresh or checked when default camera view center is set.
…alogs This prevents emitting signals that lead to countless updates when a single one is necessary, thus causing some freezes in the interface.
fabiencastan
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR performs the upgrade from Qt5.15.2 / PySide2 5.15.2 to Qt6.6.3 / PySide6.6.3.1, and does not include the update to the Dockerfiles, which will be part of an ulterior pull request.
It additionally integrates all the changes from #2444.
QtAliceVision pull request: alicevision/QtAliceVision#79