Minor code clean-up and QML warning and error fixes #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
dev/minorCleanUp
branch
from
7aa1cde to
6e6e6a7
Compare
This commit fixes the following errors: - "<Unknown File>: Can't assign to existing role 'value' of different type [VariantMap -> String]" which occurs whenever the metadata view is enabled and appears if at least one of the metadata keys has an empty value; - "Unable to assign [undefined] to QString" which occurs whenever the search bar is cleared.
…abel This fixes a "TypeError: Cannot read property 'label' of null" issue.
cbentejac
force-pushed
the
dev/minorCleanUp
branch
from
6e6e6a7 to
6d4c832
Compare
fabiencastan
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following:
binding loopwarnings in the Graph Editor, and more specifically, in the AttributeItemDelegate, which appeared whenever a ListAttribute was being expanded;<Unknown File>: Can't assign to existing role 'value' of different type [VariantMap -> String]error which occurred whenever the metadata view was enabled if at least one of the metadata keys had an empty value;Unable to assign [undefined] to QStringerror which occurred whenever the search bar was cleared;TypeError: Cannot read property '' of nullerror which occurred when loading a new project file while the Feature Viewer was enabled.The content of the nodes' description itself is not improved and is not part of the scope of this PR.