[ui] ImageGallery: Use commands to set SfM attributes through the Image Gallery #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lery Prior to this commit, the `StructureFromMotion` and `SfMTransform` nodes' were directly set without using the dedicated command. This meant that the actions to set those attributes through the Image Gallery menu were not added to the stack of commands, and could not be undone.
fabiencastan
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some attributes of the
StructureFromMotionandSfMTransformnodes can be set directly through the Image Gallery with the right-click menu. Prior to this PR, setting these attributes through the Image Gallery was directly modifying them without adding the changes to the stack of commands, meaning they could not be undone.This PR fixes that by using the "setAttribute" command to modify these attributes, which correctly adds them to the stack and allows to undo them with Ctrl-Z.