Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gray mode migrate accerate #12957

Merged
merged 5 commits into from
Dec 17, 2024
Merged

gray mode migrate accerate #12957

merged 5 commits into from
Dec 17, 2024

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

灰度模型迁移程序并发&迁移不落历史表

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.80822% with 60 lines in your changes missing coverage. Please review.

Project coverage is 72.37%. Comparing base (98c9760) to head (7a558dd).

Files with missing lines Patch % Lines
.../server/service/ConfigGrayModelMigrateService.java 0.00% 54 Missing ⚠️
...dded/EmbeddedConfigInfoGrayPersistServiceImpl.java 71.42% 0 Missing and 2 partials ⚠️
...rnal/ExternalConfigInfoGrayPersistServiceImpl.java 75.00% 0 Missing and 2 partials ⚠️
...source/impl/mysql/ConfigInfoGrayMapperByMySql.java 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12957      +/-   ##
=============================================
- Coverage      72.41%   72.37%   -0.05%     
- Complexity      9959     9961       +2     
=============================================
  Files           1307     1307              
  Lines          41783    41819      +36     
  Branches        4389     4395       +6     
=============================================
+ Hits           30258    30267       +9     
- Misses          9410     9433      +23     
- Partials        2115     2119       +4     
Files with missing lines Coverage Δ
...libaba/nacos/config/server/utils/PropertyUtil.java 93.75% <100.00%> (+0.03%) ⬆️
...dded/EmbeddedConfigInfoGrayPersistServiceImpl.java 80.79% <71.42%> (-1.03%) ⬇️
...rnal/ExternalConfigInfoGrayPersistServiceImpl.java 78.45% <75.00%> (-0.88%) ⬇️
...source/impl/mysql/ConfigInfoGrayMapperByMySql.java 40.00% <0.00%> (+6.66%) ⬆️
.../server/service/ConfigGrayModelMigrateService.java 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c9760...7a558dd. Read the comment docs.

@KomachiSion KomachiSion merged commit 80b44bc into alibaba:develop Dec 17, 2024
8 checks passed
@wuyfee
Copy link

wuyfee commented Dec 17, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion KomachiSion added this to the 2.5.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants