Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12925] Optimize configuration history comparison and rollback. #12942

Merged
merged 14 commits into from
Dec 18, 2024

Conversation

DirtyBit64
Copy link
Contributor

@DirtyBit64 DirtyBit64 commented Dec 12, 2024

What is the purpose of the change

resolve #12925

Brief changelog

Add API-getConfigHistoryInfoPair : Query history configuration information details and version changes, including the original version and the changed version.

新增 API-getConfigHistoryInfoPair
查询历史配置信息详情及版本变更,包括原始版本和变更后的版本。

Verifying this change

Api test: done
Unit test: testGetConfigHistoryInfoPair
Joint debugging test:TODO

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

…story information pair, including original version and updated version.
Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@DirtyBit64 DirtyBit64 changed the title [ISSUE #12925] Optimize configuration history comparison and rollback.Develop pair. [ISSUE #12925] Optimize configuration history comparison and rollback. Dec 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 54.03727% with 74 lines in your changes missing coverage. Please review.

Project coverage is 72.27%. Comparing base (98c9760) to head (0f6553a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ba/nacos/config/server/service/HistoryService.java 50.00% 14 Missing and 5 partials ⚠️
...l/ExternalHistoryConfigInfoPersistServiceImpl.java 0.00% 18 Missing ⚠️
...cos/config/server/model/ConfigHistoryInfoPair.java 81.94% 13 Missing ⚠️
...d/EmbeddedHistoryConfigInfoPersistServiceImpl.java 0.00% 11 Missing ⚠️
...gin/datasource/mapper/HistoryConfigInfoMapper.java 0.00% 11 Missing ⚠️
...ibaba/nacos/config/server/enums/OperationType.java 80.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12942      +/-   ##
=============================================
- Coverage      72.41%   72.27%   -0.15%     
- Complexity      9959    10003      +44     
=============================================
  Files           1307     1309       +2     
  Lines          41783    41979     +196     
  Branches        4389     4411      +22     
=============================================
+ Hits           30258    30339      +81     
- Misses          9410     9517     +107     
- Partials        2115     2123       +8     
Files with missing lines Coverage Δ
...os/config/server/controller/HistoryController.java 84.61% <100.00%> (+1.28%) ⬆️
.../extrnal/ExternalConfigInfoPersistServiceImpl.java 76.38% <ø> (ø)
...cos/plugin/datasource/constants/FieldConstant.java 0.00% <ø> (ø)
...ibaba/nacos/config/server/enums/OperationType.java 80.00% <80.00%> (ø)
...d/EmbeddedHistoryConfigInfoPersistServiceImpl.java 85.71% <0.00%> (-10.84%) ⬇️
...gin/datasource/mapper/HistoryConfigInfoMapper.java 56.00% <0.00%> (-44.00%) ⬇️
...cos/config/server/model/ConfigHistoryInfoPair.java 81.94% <81.94%> (ø)
...l/ExternalHistoryConfigInfoPersistServiceImpl.java 85.27% <0.00%> (-13.83%) ⬇️
...ba/nacos/config/server/service/HistoryService.java 59.09% <50.00%> (-13.33%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c9760...0f6553a. Read the comment docs.

@wuyfee
Copy link

wuyfee commented Dec 13, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@wuyfee
Copy link

wuyfee commented Dec 13, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@shiyiyue1102
Copy link
Collaborator

merge develop brach after this pr #12947 being merged into develop

@wuyfee
Copy link

wuyfee commented Dec 16, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@wuyfee
Copy link

wuyfee commented Dec 17, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@shiyiyue1102 shiyiyue1102 self-requested a review December 18, 2024 02:48
@shiyiyue1102 shiyiyue1102 merged commit d30bff0 into alibaba:develop Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[optimize] config history comparison and rollback function optimize
4 participants