Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error message is not user-friendly when adding duplicate permissi… #12803

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

littlesparklet
Copy link
Contributor

…ons. (#12773)

What is the purpose of the change

To solve this problem: The error message is not user-friendly when adding duplicate permissions

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.26%. Comparing base (2a0dafa) to head (568707c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #12803   +/-   ##
==========================================
  Coverage      72.25%   72.26%           
- Complexity      9826     9827    +1     
==========================================
  Files           1287     1287           
  Lines          41445    41445           
  Branches        4373     4373           
==========================================
+ Hits           29947    29949    +2     
+ Misses          9396     9395    -1     
+ Partials        2102     2101    -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0dafa...568707c. Read the comment docs.

@KomachiSion
Copy link
Collaborator

whether depend on #12805?

@littlesparklet
Copy link
Contributor Author

depend

Yes, It indeed depends on #12805. we work together on this.

@KomachiSion
Copy link
Collaborator

I comment in #12805, the api response might be changed. console-ui may be need changes.

…op-self

# Conflicts:
#	console/src/main/resources/static/index.html
#	console/src/main/resources/static/js/main.js
@wuyfee
Copy link

wuyfee commented Nov 29, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@wuyfee
Copy link

wuyfee commented Nov 29, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@littlesparklet
Copy link
Contributor Author

I comment in #12805, the api response might be changed. console-ui may be need changes.

The api response has changed, and I changed the console-ui according to the api response.

@KomachiSion KomachiSion merged commit 4961191 into alibaba:develop Dec 5, 2024
7 checks passed
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Nacos console Related to Nacos consle labels Dec 5, 2024
@KomachiSion KomachiSion added this to the 2.5.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants