Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #11718] Fix ErrorCode have the same code #11747

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

easynet-cn
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix ISSUE #11718

Brief changelog

1: Define NODE_DOWN_FAILURE code 23002
2: Add test

Verifying this change

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ee724e) 67.87% compared to head (5fc5204) 67.86%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11747      +/-   ##
=============================================
- Coverage      67.87%   67.86%   -0.01%     
- Complexity      8895     8896       +1     
=============================================
  Files           1237     1237              
  Lines          40469    40469              
  Branches        4290     4290              
=============================================
- Hits           27469    27466       -3     
- Misses         11024    11028       +4     
+ Partials        1976     1975       -1     
Files Coverage Δ
...java/com/alibaba/nacos/api/model/v2/ErrorCode.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee724e...5fc5204. Read the comment docs.

@KomachiSion KomachiSion merged commit 1d3f1bb into alibaba:develop Feb 20, 2024
7 checks passed
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Feb 20, 2024
@KomachiSion KomachiSion added this to the 2.3.1 milestone Feb 20, 2024
@easynet-cn easynet-cn deleted the fix-11718 branch February 20, 2024 06:12
huangkemingyyds pushed a commit to huangkemingyyds/nacos that referenced this pull request Feb 20, 2024
* [ISSUE alibaba#11718] Fix ErrorCode have the same code

* Fix code style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants