Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #11708]fix dark mode bugs #11740

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

985492783
Copy link
Contributor

fix #11708
dark mode has some wrong color

  1. fix scrollbar color
  2. fix notice message box color
  3. fix normal-button and pagination-button color
    image
    image

@985492783 985492783 closed this Feb 6, 2024
@985492783 985492783 reopened this Feb 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (9d473ef) 66.75% compared to head (049c15b) 67.82%.
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11740      +/-   ##
=============================================
+ Coverage      66.75%   67.82%   +1.06%     
- Complexity      8815     8892      +77     
=============================================
  Files           1238     1237       -1     
  Lines          40545    40476      -69     
  Branches        4298     4291       -7     
=============================================
+ Hits           27066    27452     +386     
+ Misses         11524    11052     -472     
- Partials        1955     1972      +17     
Files Coverage Δ
...alibaba/nacos/client/config/impl/ClientWorker.java 76.40% <100.00%> (+20.49%) ⬆️
...aming/push/v2/hook/NacosMonitorPushResultHook.java 64.70% <100.00%> (+2.20%) ⬆️
...nacos/plugin/config/ConfigChangePluginManager.java 70.21% <73.33%> (-5.40%) ⬇️
...nacos/config/server/aspect/ConfigChangeAspect.java 84.56% <79.41%> (+4.68%) ⬆️

... and 41 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bb9398...049c15b. Read the comment docs.

@KomachiSion KomachiSion added the area/Nacos console Related to Nacos consle label Feb 20, 2024
@KomachiSion KomachiSion added this to the 2.3.1 milestone Feb 20, 2024
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Feb 20, 2024
@KomachiSion KomachiSion merged commit e6eb636 into alibaba:develop Feb 20, 2024
12 of 13 checks passed
huangkemingyyds pushed a commit to huangkemingyyds/nacos that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

深色主题UI适配不完美
3 participants