Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: support get java cmd from which java #11720

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

slievrly
Copy link
Member

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

support get java cmd from which java

Brief changelog

support get java cmd from which java

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR has no problem, please sync from the develop branch to fix the ut problem.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (139f4f2) 67.83% compared to head (dd8a7bb) 67.78%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11720      +/-   ##
=============================================
- Coverage      67.83%   67.78%   -0.05%     
+ Complexity      8891     8882       -9     
=============================================
  Files           1237     1237              
  Lines          40476    40476              
  Branches        4291     4291              
=============================================
- Hits           27455    27436      -19     
- Misses         11048    11065      +17     
- Partials        1973     1975       +2     

see 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 139f4f2...dd8a7bb. Read the comment docs.

@slievrly
Copy link
Member Author

PR has no problem, please sync from the develop branch to fix the ut problem.

resolved.

@KomachiSion KomachiSion merged commit 3c278ed into alibaba:develop Feb 20, 2024
7 checks passed
huangkemingyyds pushed a commit to huangkemingyyds/nacos that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants