Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metric for grpc server executor #11428

Merged

Conversation

Daydreamer-ia
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#10846
XXXXX

# HELP grpc_server_executor  
# TYPE grpc_server_executor gauge
grpc_server_executor{module="core",name="maximumPoolSize",type="grpcClusterServer",} 256.0
grpc_server_executor{module="core",name="corePoolSize",type="grpcClusterServer",} 256.0
grpc_server_executor{module="core",name="taskCount",type="grpcSdkServer",} 62.0
grpc_server_executor{module="core",name="taskCount",type="grpcClusterServer",} 0.0
grpc_server_executor{module="core",name="poolSize",type="grpcSdkServer",} 62.0
grpc_server_executor{module="core",name="activeCount",type="grpcSdkServer",} 0.0
grpc_server_executor{module="core",name="activeCount",type="grpcClusterServer",} 0.0
grpc_server_executor{module="core",name="poolSize",type="grpcClusterServer",} 0.0
grpc_server_executor{module="core",name="completedTaskCount",type="grpcClusterServer",} 0.0
grpc_server_executor{module="core",name="inQueueTaskCount",type="grpcClusterServer",} 0.0
grpc_server_executor{module="core",name="maximumPoolSize",type="grpcSdkServer",} 256.0
grpc_server_executor{module="core",name="completedTaskCount",type="grpcSdkServer",} 62.0
grpc_server_executor{module="core",name="corePoolSize",type="grpcSdkServer",} 256.0
grpc_server_executor{module="core",name="inQueueTaskCount",type="grpcSdkServer",} 0.0

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@Daydreamer-ia Daydreamer-ia changed the title Feat/grpc server executor mertic Support metric for grpc server executor Nov 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

Merging #11428 (507b6f3) into develop (380c019) will increase coverage by 0.03%.
The diff coverage is 71.95%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11428      +/-   ##
=============================================
+ Coverage      61.50%   61.53%   +0.03%     
- Complexity      6836     6839       +3     
=============================================
  Files           1065     1066       +1     
  Lines          31517    31599      +82     
  Branches        3250     3251       +1     
=============================================
+ Hits           19385    19445      +60     
- Misses         10786    10808      +22     
  Partials        1346     1346              
Files Coverage Δ
...com/alibaba/nacos/core/monitor/MetricsMonitor.java 99.09% <100.00%> (+1.05%) ⬆️
...acos/core/monitor/GrpcServerThreadPoolMonitor.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380c019...507b6f3. Read the comment docs.

KomachiSion
KomachiSion previously approved these changes Dec 5, 2023
# Conflicts:
#	core/src/main/java/com/alibaba/nacos/core/monitor/MetricsMonitor.java
@KomachiSion KomachiSion merged commit 01a28ee into alibaba:develop Dec 6, 2023
7 checks passed
@KomachiSion KomachiSion added this to the 2.3.1 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants