Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop refactor topn #11352

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: Patch coverage is 89.47368% with 10 lines in your changes missing coverage. Please review.

Project coverage is 60.41%. Comparing base (0d46af0) to head (d9e3a79).
Report is 311 commits behind head on develop.

Files with missing lines Patch % Lines
...ming/monitor/NamingDynamicMeterRefreshService.java 0.00% 3 Missing ⚠️
...ibaba/nacos/core/monitor/topn/BaseTopNCounter.java 92.30% 0 Missing and 2 partials ⚠️
...om/alibaba/nacos/core/monitor/topn/TopNConfig.java 85.71% 2 Missing ⚠️
...m/alibaba/nacos/naming/monitor/MetricsMonitor.java 50.00% 2 Missing ⚠️
...ibaba/nacos/naming/monitor/ServiceTopNCounter.java 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11352      +/-   ##
=============================================
- Coverage      60.50%   60.41%   -0.10%     
- Complexity      5836     5845       +9     
=============================================
  Files            883      887       +4     
  Lines          26827    26833       +6     
  Branches        2770     2767       -3     
=============================================
- Hits           16231    16210      -21     
- Misses          9481     9507      +26     
- Partials        1115     1116       +1     
Files with missing lines Coverage Δ
...acos/core/monitor/topn/FixedSizePriorityQueue.java 100.00% <100.00%> (ø)
...aba/nacos/core/monitor/topn/StringTopNCounter.java 100.00% <100.00%> (ø)
.../naming/push/v2/NamingSubscriberServiceV2Impl.java 76.19% <100.00%> (ø)
...ibaba/nacos/naming/monitor/ServiceTopNCounter.java 66.66% <66.66%> (ø)
...ibaba/nacos/core/monitor/topn/BaseTopNCounter.java 92.30% <92.30%> (ø)
...om/alibaba/nacos/core/monitor/topn/TopNConfig.java 85.71% <85.71%> (ø)
...m/alibaba/nacos/naming/monitor/MetricsMonitor.java 86.77% <50.00%> (-0.73%) ⬇️
...ming/monitor/NamingDynamicMeterRefreshService.java 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d46af0...d9e3a79. Read the comment docs.

@KomachiSion KomachiSion merged commit e77a0bb into alibaba:develop Nov 9, 2023
6 checks passed
lowezheng added a commit to lowezheng/nacos that referenced this pull request Nov 12, 2023
* develop: (137 commits)
  Develop refactor topn (alibaba#11352)
  Develop fill ut common (alibaba#11335)
  Optimize MapperManager (alibaba#11195)
  Simplify the validate method for serviceinfo (alibaba#11312)
  add startup conditions (alibaba#11305)
  Fix some typos (alibaba#11269)
  fix: rename tar name (alibaba#11281)
  优化节点显示,添加mode (alibaba#11275)
  [ISSUE alibaba#11253]To fix the triggering of the listener upon failover con… (alibaba#11254)
  Add description for new plugin. (alibaba#11268)
  Upgrade to 2.3.0-BETA. (alibaba#11262)
  [ISSUE alibaba#11255]Update PathEncoderManagerTest#testEncodeWithNonExistOs. (alibaba#11256)
  Fill ut for common module (alibaba#11247)
  Optimize ThreadPoolManager (alibaba#11206)
  Fix npe when setup ack response in GrpcClient (alibaba#11210)
  [ISSUE#11192] batchRegisterInstance add recalculateRevision (alibaba#11232)
  feat(alibaba#11236): Remove invalid assertion in com.alibaba.nacos.config.server.service.ConfigCacheService#dumpChange. (alibaba#11237)
  feat(11115): http support cas publish. (alibaba#11120)
  [ISSUE alibaba#11231]Optimize the handleSpringBinder method in PropertiesUtil. (alibaba#11240)
  ISSUE alibaba#11212 (alibaba#11213)
  ...

# Conflicts:
#	console-ui/package-lock.json
#	console-ui/package.json
#	console-ui/src/pages/Login/Login.jsx
#	core/src/main/java/com/alibaba/nacos/core/listener/StartingApplicationListener.java
#	pom.xml
@KomachiSion KomachiSion deleted the develop_refactor_topn branch May 31, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants