-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #11343] Simplified validation logic #11345
Conversation
link #11343 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #11345 +/- ##
=============================================
- Coverage 60.50% 60.46% -0.05%
+ Complexity 5836 5826 -10
=============================================
Files 883 885 +2
Lines 26827 26738 -89
Branches 2770 2763 -7
=============================================
- Hits 16231 16166 -65
+ Misses 9481 9460 -21
+ Partials 1115 1112 -3
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一个问题
注解里的参数为checker,但是指定的是参数提取用的extractor, 是不是改下名字。
done |
Simplified validation logic and fix bug.
优化点
修改点
@ParamChecker.Checker
注解。将控制权转给controller,类似@Secured
注解定义资源类型。Optimisation points
Modification points
@ParamChecker.Checker
annotation. Transfer control to controller, similar to@Secured
annotation to define resource type.