[ISSUE #11414]Optimize ServiceInfo.validate() to reduce memory usage (#…

…11415)
alibaba · Nov 24, 2023 · 44b0891 · 44b0891
1 parent c42981c
commit 44b0891
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/api/src/main/java/com/alibaba/nacos/api/naming/pojo/ServiceInfo.java b/api/src/main/java/com/alibaba/nacos/api/naming/pojo/ServiceInfo.java
@@ -188,18 +188,14 @@ public boolean validate() {
             return false;
         }
 
-        List<Instance> validHosts = new ArrayList<>();
+        boolean existValidHosts = false;
         for (Instance host : hosts) {
-            if (!host.isHealthy()) {
-                continue;
-            }
-
-            if (host.getWeight() > 0) {
-                validHosts.add(host);
+            if (host.isHealthy() && host.getWeight() > 0) {
+                existValidHosts = true;
+                break;
             }
         }
-        //No valid hosts, return false.
-        return !validHosts.isEmpty();
+        return existValidHosts;
     }
 
     @JsonIgnore