Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][metric] change log print level for meeting metric already registered #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TyrantLucifer
Copy link
Contributor

change log print level for meeting metric already registered, when user use sql-client executor multi ad-hoc, it will print redundant log, it maybe mislead user.

image

@luoyuxia
Copy link
Collaborator

luoyuxia commented Dec 2, 2024

@TyrantLucifer Thanks for you attention. But register a metric with same name does is not expected, I would like to keep it as warning level. The key point is that the client register the metric with same name for more than once. We shuld fix it from client side. I'm wondering why it'll be register for more than once. Seem when FlussConnection is closed, ConnectionMetricGroup is not closed, so it'll register the same metrics again after init the connection in another query.

@TyrantLucifer
Copy link
Contributor Author

@TyrantLucifer Thanks for you attention. But register a metric with same name does is not expected, I would like to keep it as warning level. The key point is that the client register the metric with same name for more than once. We shuld fix it from client side. I'm wondering why it'll be register for more than once. Seem when FlussConnection is closed, ConnectionMetricGroup is not closed, so it'll register the same metrics again after init the connection in another query.

Got it. I will try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants