Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix seq number error #234

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[docs] fix seq number error #234

wants to merge 2 commits into from

Conversation

JNSimba
Copy link

@JNSimba JNSimba commented Dec 20, 2024

Purpose

fix seq number error

Copy link
Collaborator

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JNSimba Thanks for the pr. I left one comment

7. Under "General", enable your preferred settings for when to format the code, e.g. "Activate save actions on save".
8. Under "Formatting Actions", select "Optimize imports" and "Reformat file".
9. Under "File Path Inclusions", add an entry for `.*\.java` to avoid formatting other file types.
1. Go to "Settings" → "Other Settings" → "Save Actions".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/alibaba/fluss/pull/234/files#diff-a196e06cbb74e690aab3e19dcf834dfddb0ce960a80ec2d50386600558890c75L102
should be change to 4, and then the seq number also should be change to 4.....

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@JNSimba JNSimba requested a review from luoyuxia December 20, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants