Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix none src model and skip load ckpt for vllm #43

Closed
wants to merge 3 commits into from
Closed

fix none src model and skip load ckpt for vllm #43

wants to merge 3 commits into from

Conversation

stcy07
Copy link
Collaborator

@stcy07 stcy07 commented Aug 30, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

adoda
adoda previously approved these changes Aug 30, 2024
View reviewed changes
haolin-nju
haolin-nju previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@haolin-nju haolin-nju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stcy07 stcy07 requested a review from SeaOfOcean August 30, 2024 07:21
@stcy07 stcy07 dismissed stale reviews from haolin-nju and adoda via 51b75c1 August 30, 2024 07:26
@stcy07 stcy07 closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haolin-nju haolin-nju haolin-nju left review comments

@adoda adoda adoda left review comments

@SeaOfOcean SeaOfOcean Awaiting requested review from SeaOfOcean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stcy07 @CLAassistant @SeaOfOcean @adoda @haolin-nju