Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bumping version to re trigger semantic releases to fix last failed run #5

Merged
merged 2 commits into from
Jul 25, 2024
Merged

ci: bumping version to re trigger semantic releases to fix last failed run #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0358f98
ci: bumping version to re trigger semantic releases to fix last faile…
aorumbayev Jul 24, 2024
ff7b1d5
chore: patching typo in conditionals for workflow dispatch bool params
aorumbayev Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ jobs:
contents: write
packages: read
env:
DRY_RUN: ${{ github.event_name == 'workflow_dispatch' && (github.event.inputs.dry_run && '--noop' || '') || '' }}
PRERELEASE: ${{ github.event_name == 'workflow_dispatch' && (github.event.inputs.prerelease && 'true' || '') || 'true' }}
DRY_RUN: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.dry_run == 'true' && '--noop' || '' }}
PRERELEASE: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.prerelease || 'true' }}
steps:
- uses: actions/checkout@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "hatchling.build"

[project]
name = "algorand-python-testing"
version = "0.2.2-beta.1"
version = "0.2.2-beta.2"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-makerx i checked on a forked branch that a manual bump in version would result in semantic releases correctly bumping it, however doing a prod release auto sets initial tag to 0.1.0 for some reason and i suspect its due to the fact that latest available tag is suffixed with beta - so technically we got 0 releases so far but not sure why the bot starts the non beta tag from 0.1.0. I'll deal with this one later on but i think we would also need to set a tag according to latest pypi version which isn't a beta one (so that bot wouldn't start the first release from 0.1.0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the 0.1.0 release would be because of a feat: conventional commit, so it would start with 0.0.0 find the feat commit and then infer the next version should be 0.1.0

description = 'Algorand Python testing library'
readme = "README.md"
requires-python = ">=3.12"
Expand Down