Allow no posts pagination #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebouquetin
requested changes
Jul 26, 2024
jssg/models.py
Outdated
| self.nb_pages = ceil(len(list(filter(lambda p: p.metadata["category"] == self.category, Post.load_glob(all=True)))) / self.posts_by_page) # number of posts of the category / number of posts by page | ||
| nb_posts = len(list(filter(lambda p: p.metadata["category"] == self.category, Post.load_glob(all=True)))) | ||
|
|
||
| if hasattr(settings, "JFME_NUMBER_OF_POSTS_BY_PAGE") : |
There was a problem hiding this comment.
It's not a common way to disable a feature to remove the parameter ; the right way is to have a default value.
I suggest here to replace
if hasattr(settings, "JFME_NUMBER_OF_POSTS_BY_PAGE") :
With
if settings.JFME_NUMBER_OF_POSTS_BY_PAGE <= 0:
This way the parameter is always available; this is a common pattern to set to 0 or -1 an attribute in order to tell "this is unlimited"
lebouquetin
approved these changes
Jul 26, 2024
lebouquetin
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #46