Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format-html command #42

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Add format-html command #42

merged 5 commits into from
Jul 24, 2024

Conversation

ClmntBcqt
Copy link
Contributor

PR for issue #41

@ClmntBcqt ClmntBcqt requested a review from lebouquetin July 18, 2024 14:32
Copy link
Member

@lebouquetin lebouquetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor upgrade of the inline help required, then it can be merged

README.md Outdated
@@ -128,6 +128,8 @@ For each command, the option `-h` give u some help.
`./manage.py make-widgets` to make a file that groups all jinja2 widgets macros for easier includes. It is automatically called by `runserver` and `distill-local` commands. \
See an example in `EXAMPLE.md`

`./manage.py format-html` to minify or beautify the html content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way to use this feature is manage.py format-html or ( manage.py format-html minify or manage.py format-html beautify) ? If the second, the the explanation is not enoug. You should write something like: ./manage.py format-html <action> to minify or beautify the html content (<action> being minify or beautify)

nargs='?',
type=str,
default=str(settings.DIST_DIR),
help="To specify a particular dist path"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add explanation that default path is the DIST_DIR. Probably the right way to help is:

            help="To specify a particular dist path. Default is: "+str(settings.DIST_DIR)

@ClmntBcqt ClmntBcqt merged commit 1042e9d into main Jul 24, 2024
2 checks passed
@ClmntBcqt ClmntBcqt deleted the feat__41_format_html_command branch July 24, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants