feat: return error object from executed command #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is tracked as part of the ExecResult as it might otherwise be shadowed by ctx.Err().
I was seeing the following error that was otherwise swallowed by the execution due to where it was returning:
Note: the file in question wasn't being properly written/closed before being executed, hence the error message. It took me a while to figure that out.
Closes #20
How Has This Been Tested?
I wrote some tests.
How are existing users impacted? What migration steps/scripts do we need?
This adds a new field so should be mostly backwards compatible
Checklist:
I have:
git commit -s
Aside, should the contributing docs point at the inlets one?